[
https://issues.apache.org/jira/browse/FLINK-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15302154#comment-15302154
]
ASF GitHub Bot commented on FLINK-3923:
---------------------------------------
Github user aozturk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2016#discussion_r64756634
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
---
@@ -160,12 +168,13 @@ public void
setCustomPartitioner(KinesisPartitioner<OUT> partitioner) {
public void open(Configuration parameters) throws Exception {
super.open(parameters);
- KinesisProducerConfiguration config = new
KinesisProducerConfiguration();
- config.setRegion(this.region);
- config.setCredentialsProvider(new StaticCredentialsProvider(new
BasicAWSCredentials(this.accessKey, this.secretKey)));
+ KinesisProducerConfiguration producerConfig = new
KinesisProducerConfiguration();
+
+
producerConfig.setRegion(configProps.getProperty(KinesisConfigConstants.CONFIG_AWS_REGION));
+
producerConfig.setCredentialsProvider(AWSUtil.getCredentialsProvider(configProps));
//config.setCollectionMaxCount(1);
//config.setAggregationMaxCount(1);
--- End diff --
Sorry again for my late response. Meanwhile I have thought about this and I
have come up with a question. I had noticed a remark about not using the KCL
library, but is there any special reason why we are not using KPL? Anything we
intend to do will probably replicate it including retry mechanism on failures,
multi-threading and asynchronous writes.
We also need to take into consideration that our producer solution should
be cost effective by using the opportunities for batching, which can be
customized by the user if low latency is preferred.
> Unify configuration conventions of the Kinesis producer to the same as the
> consumer
> -----------------------------------------------------------------------------------
>
> Key: FLINK-3923
> URL: https://issues.apache.org/jira/browse/FLINK-3923
> Project: Flink
> Issue Type: Sub-task
> Components: Kinesis Connector, Streaming Connectors
> Affects Versions: 1.1.0
> Reporter: Robert Metzger
> Assignee: Abdullah Ozturk
>
> Currently, the Kinesis consumer and producer are configured differently.
> The producer expects a list of arguments for the access key, secret, region,
> stream. The consumer is accepting properties (similar to the Kafka connector).
> The objective of this issue is to change the producer so that it is also
> using a properties-based configuration (including an input validation step)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
