SteNicholas commented on a change in pull request #16023:
URL: https://github.com/apache/flink/pull/16023#discussion_r642060875
##########
File path:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSource.java
##########
@@ -322,14 +323,28 @@ private void processMessage(Delivery delivery,
RMQCollectorImpl collector) throw
deliveryDeserializer.deserialize(envelope, properties, body,
collector);
}
+ /**
+ * Returns the next message delivery timeout used in the queueing
consumer. If not specified in
+ * the provided connection config, the default value of 30000 milliseconds
will be returned.
+ *
+ * @return consumer delivery timeout in milliseconds
+ */
+ protected int getDeliveryTimeout() {
+ return
rmqConnectionConfig.getDeliveryTimeout().orElse(DEFAULT_DELIVERY_TIMEOUT);
Review comment:
Should this default value for delivery timeout put into the constructor
of `RMQConnectionConfig` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
