SteNicholas commented on a change in pull request #16023:
URL: https://github.com/apache/flink/pull/16023#discussion_r642175971



##########
File path: 
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/common/RMQConnectionConfig.java
##########
@@ -506,16 +532,44 @@ public Builder setPrefetchCount(int prefetchCount) {
             return this;
         }
 
+        /**
+         * Enables setting the next message delivery timeout in the queueing 
consumer. Only
+         * applicable to the {@link RMQSource}. Set to 0 for unlimited (the 
consumer will be blocked
+         * until an element becomes available). Default is 30000.
+         *
+         * @param deliveryTimeout maximum wait time, in milliseconds, for the 
next message delivery
+         * @return the Builder
+         */
+        public Builder setDeliveryTimeout(int deliveryTimeout) {
+            this.deliveryTimeout = deliveryTimeout;

Review comment:
       Why doesn't this check whether deliveryTimeout is negative?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to