cmick opened a new pull request #16023:
URL: https://github.com/apache/flink/pull/16023


   ## What is the purpose of the change
   
   *This pull request enables setting the next message delivery timeout in the 
RabbitMQ queueing consumer, allowing to properly stop the job in cases when no 
new message is available on the queue (issue 
[FLINK-22698](https://issues.apache.org/jira/browse/FLINK-22698)).*
   
   ## Brief change log
   
    - adds the ability to `setDeliveryTimeout` on the `RMQConnectionConfig` and 
its builder
    - change default message delivery timeout in the `RMQSource` to 30 seconds 
(previously there was no timeout)
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
    - `RMQSourceTest#testSetDeliveryTimeout` and  
`RMQConnectionConfigTest#shouldSetOptionalDeliveryTimeout`, which tests setting 
a custom delivery timeout
    - `RMQSourceTest#testDefaultDeliveryTimeout`, which tests using a default 
delivery timeout, when custom is not provided
    - `RMQSourceTest#testDeliveryTimeout`, which tests correct cancelling of 
the source when no new messages are available
    - `RMQConnectionConfigTest#shouldReturnEmptyOptionalDeliveryTimeout`, which 
tests the returned Optional is empty when not set specifically
    - 
`RMQConnectionConfigTest#shouldThrowIllegalArgumentExceptionIfDeliveryTimeoutIsNegative`,
 which tests against invalid timeout values
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **no**
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: **no**
     - The serializers: **no**
     - The runtime per-record code paths (performance sensitive):  **no**
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper:  **no**
     - The S3 file system connector: **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature? **yes**
     - If yes, how is the feature documented? **JavaDocs**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to