kezhuw commented on a change in pull request #15425:
URL: https://github.com/apache/flink/pull/15425#discussion_r604609919



##########
File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SourceOperatorStreamTask.java
##########
@@ -97,6 +97,11 @@ public void init() throws Exception {
         inputProcessor = new StreamOneInputProcessor<>(input, output, 
operatorChain);
     }
 
+    @Override
+    protected void finishTask() throws Exception {
+        stopMailboxProcessor();

Review comment:
       > it would brake clean shutdown of stop-with-savepoint WITH drain
   
   Agree. If not currently, then it will break when savepoint for drain moving 
after end-input-flushing operation. In that case, the whole task should 
function normally just no input anymore.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to