kezhuw commented on a change in pull request #15425:
URL: https://github.com/apache/flink/pull/15425#discussion_r603772188
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SourceOperatorStreamTask.java
##########
@@ -97,6 +97,11 @@ public void init() throws Exception {
inputProcessor = new StreamOneInputProcessor<>(input, output,
operatorChain);
}
+ @Override
+ protected void finishTask() throws Exception {
+ stopMailboxProcessor();
Review comment:
A discussion between me and @pnowojski in FLINK-21821 convinces me that
`cancelables` should resides in two code path `cancel` and `cleanUpInvoke` to
cancel/cleanup possible background activities. I think `cancelables.close` in
`finishTask` is unnecessary at least, possibly not harmful also. I would like
to not call `cancelables.close` in new code path, at least in this fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
