pnowojski commented on a change in pull request #15425:
URL: https://github.com/apache/flink/pull/15425#discussion_r604664970



##########
File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SourceOperatorStreamTask.java
##########
@@ -97,6 +97,11 @@ public void init() throws Exception {
         inputProcessor = new StreamOneInputProcessor<>(input, output, 
operatorChain);
     }
 
+    @Override
+    protected void finishTask() throws Exception {
+        stopMailboxProcessor();

Review comment:
       If you go through the annotations/git blame of the cancellables and how 
were they introduced (you need to go through two or three levels of changes), 
you will find this: https://issues.apache.org/jira/browse/FLINK-3466
   
   and commit message:
   
   > [FLINK-3466] [runtime] Make state handles cancelable.  
   > 
   > State handles are cancelable, to make sure long running checkpoint restore 
operations do finish early on cancallation, even if the code does not properly 
react to interrupts.
   >
   > This is especially important since HDFS client code is so buggy that it 
deadlocks when interrupted without closing.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to