[ 
https://issues.apache.org/jira/browse/FLINK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15241477#comment-15241477
 ] 

ASF GitHub Bot commented on FLINK-2998:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1838#discussion_r59751421
  
    --- Diff: 
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/CustomDistributionITCase.java
 ---
    @@ -175,6 +175,77 @@ else if (pIdx > 0 && pIdx < dist.getParallelism() - 1) 
{
                env.execute();
        }
     
    +   @Test
    +   public void testPartitionKeyLessDistribution() throws Exception{
    +           /*
    +            * Test the number of keys less than the number of distribution 
fields
    +            */
    +
    +           ExecutionEnvironment env = 
ExecutionEnvironment.createLocalEnvironment();
    +
    +           DataSet<Tuple3<Integer, Long, String>> input1 = 
CollectionDataSets.get3TupleDataSet(env);
    +           final TestDataDist2 dist = new TestDataDist2();
    +
    +           env.setParallelism(dist.getParallelism());
    +
    +           DataSet<Boolean> result = DataSetUtils
    +                           .partitionByRange(input1, dist, 0)
    +                           .mapPartition(new 
RichMapPartitionFunction<Tuple3<Integer, Long, String>, Boolean>() {
    +
    +                                                             @Override
    --- End diff --
    
    Can you adjust the indention to be as in the other test methods?


> Support range partition comparison for multi input nodes.
> ---------------------------------------------------------
>
>                 Key: FLINK-2998
>                 URL: https://issues.apache.org/jira/browse/FLINK-2998
>             Project: Flink
>          Issue Type: New Feature
>          Components: Optimizer
>            Reporter: Chengxiang Li
>            Priority: Minor
>
> The optimizer may have potential opportunity to optimize the DAG while it 
> found two input range partition are equivalent, we does not support the 
> comparison yet.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to