[ 
https://issues.apache.org/jira/browse/FLINK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15249729#comment-15249729
 ] 

ASF GitHub Bot commented on FLINK-2998:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1838#discussion_r60395484
  
    --- Diff: 
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/CoGroupITCase.java
 ---
    @@ -301,6 +309,51 @@ public void 
testCoGroupWithMultipleKeyFieldsWithFieldSelector() throws Exception
        }
     
        @Test
    +   public void testCoGroupWithMultipleKeyFieldsWithFieldSelector2() throws 
Exception {
    +           /*
    +            * UDF Join on tuples with multiple key field positions and 
same customized distribution
    +            */
    +
    +           final ExecutionEnvironment env = 
ExecutionEnvironment.getExecutionEnvironment();
    +
    +           DataSet<Tuple5<Integer, Long, Integer, String, Integer>> ds1 = 
CollectionDataSets.get5TupleDataSet(env)
    +                           .map(new MapFunction<Tuple5<Integer, Long, 
Integer, String, Long>, Tuple5<Integer, Long, Integer, String, Integer>>() {
    --- End diff --
    
    Can you keep the original data type, i.e., not convert the last field to 
Integer? 
    1) It will check if the range partitioning handles different types.
    2) it will be more concise (no map functions + no additional 
CoGroupFunction).


> Support range partition comparison for multi input nodes.
> ---------------------------------------------------------
>
>                 Key: FLINK-2998
>                 URL: https://issues.apache.org/jira/browse/FLINK-2998
>             Project: Flink
>          Issue Type: New Feature
>          Components: Optimizer
>            Reporter: Chengxiang Li
>            Priority: Minor
>
> The optimizer may have potential opportunity to optimize the DAG while it 
> found two input range partition are equivalent, we does not support the 
> comparison yet.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to