[ https://issues.apache.org/jira/browse/FLINK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15241461#comment-15241461 ]
ASF GitHub Bot commented on FLINK-2998: --------------------------------------- Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1838#discussion_r59749772 --- Diff: flink-optimizer/src/test/java/org/apache/flink/optimizer/operators/CoGroupGlobalPropertiesCompatibilityTest.java --- @@ -95,6 +97,32 @@ public int partition(Object key, int numPartitions) { assertTrue(descr.areCompatible(reqLeft, reqRight, propsLeft, propsRight)); } + + TestDistribution dist1 = new TestDistribution(1); + TestDistribution dist2 = new TestDistribution(1); + + // test compatible range partitioning + { --- End diff -- Can you add a checks with two keys, one DESC and one ASC? Orders of both should be the same to check if it is correctly identified as compatible. > Support range partition comparison for multi input nodes. > --------------------------------------------------------- > > Key: FLINK-2998 > URL: https://issues.apache.org/jira/browse/FLINK-2998 > Project: Flink > Issue Type: New Feature > Components: Optimizer > Reporter: Chengxiang Li > Priority: Minor > > The optimizer may have potential opportunity to optimize the DAG while it > found two input range partition are equivalent, we does not support the > comparison yet. -- This message was sent by Atlassian JIRA (v6.3.4#6332)