rkhachatryan commented on a change in pull request #14683:
URL: https://github.com/apache/flink/pull/14683#discussion_r559747444
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -1278,7 +1278,12 @@ public void run() {
}
void scheduleTriggerRequest() {
- timer.execute(this::executeQueuedRequest);
+ if (isShutdown()) {
Review comment:
This is only an optimization because `timer` thread can be shutdown
after the check.
I'm concerned that adding `synchronized` might create deadlocks (if not now
then in the future).
See also thread
[above](https://github.com/apache/flink/pull/14683#discussion_r559742642).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
