rkhachatryan commented on a change in pull request #14683:
URL: https://github.com/apache/flink/pull/14683#discussion_r559742642
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointsCleaner.java
##########
@@ -62,8 +62,15 @@ public void cleanCheckpoint(
}
}
} finally {
- numberOfCheckpointsToClean.decrementAndGet();
- postCleanAction.run();
+ try {
+ numberOfCheckpointsToClean.decrementAndGet();
+ postCleanAction.run();
+ } catch (Exception e) {
+ LOG.error(
+ "Error while cleaning up checkpoint {}",
+ checkpoint.getCheckpointID(),
+ e);
Review comment:
> the contract should be that here mustn't occur any exceptions
To guarantee such a contract I see only two options:
1. Wrap `timer.execute` in `CheckpointCoordinator.scheduleTriggerRequest` in
a `syncrhonized` block.
2. Tolerate `RejecectionExecutionException && isShutdown` case as I proposed
in jira ticket.
The 1st option is deadlock-prone IMO, the 2nd requries some discussion and
rework (so not a quick solution).
Logging is also not perfect but to me it's the lesser evil.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
