tillrohrmann commented on a change in pull request #14683:
URL: https://github.com/apache/flink/pull/14683#discussion_r560057569
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointsCleaner.java
##########
@@ -62,8 +62,15 @@ public void cleanCheckpoint(
}
}
} finally {
- numberOfCheckpointsToClean.decrementAndGet();
- postCleanAction.run();
+ try {
+ numberOfCheckpointsToClean.decrementAndGet();
+ postCleanAction.run();
+ } catch (Exception e) {
+ LOG.error(
+ "Error while cleaning up checkpoint {}",
+ checkpoint.getCheckpointID(),
+ e);
Review comment:
Hmm, I guess this is related to the threading model of the
`CheckpointCoordinator`.
Could you elaborate on the deadlock you are fearing? Which other locks would
be hold by the `postCleanAction` which could cause a deadlock?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
