klion26 commented on a change in pull request #13180:
URL: https://github.com/apache/flink/pull/13180#discussion_r473623138
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/AsyncCheckpointRunnable.java
##########
@@ -129,12 +129,10 @@ public void run() {
checkpointMetaData.getCheckpointId());
}
} catch (Exception e) {
- if (LOG.isDebugEnabled()) {
- LOG.debug("{} - asynchronous part of checkpoint
{} could not be completed.",
- taskName,
- checkpointMetaData.getCheckpointId(),
- e);
- }
+ LOG.info("{} - asynchronous part of checkpoint {} could
not be completed.",
Review comment:
Honestly, I have not had this to me, I’m not against this change here.
After another look of `CheckpointFailureManager`, we have counted
`CHECKPOINT_EXPIRED` in(we will count `CHECKPOINT_EXPIRED` and
`CHECKPOINT_DECLINED` in now), before count `CHECKPOINT_EXPIRED` in, we may
have expired checkpoints, and abort the ongoing the snapshot(this may print the
log here) through `notifyCheckpointAbort` RPC.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
