klion26 commented on a change in pull request #13180:
URL: https://github.com/apache/flink/pull/13180#discussion_r473623138
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/AsyncCheckpointRunnable.java
##########
@@ -129,12 +129,10 @@ public void run() {
checkpointMetaData.getCheckpointId());
}
} catch (Exception e) {
- if (LOG.isDebugEnabled()) {
- LOG.debug("{} - asynchronous part of checkpoint
{} could not be completed.",
- taskName,
- checkpointMetaData.getCheckpointId(),
- e);
- }
+ LOG.info("{} - asynchronous part of checkpoint {} could
not be completed.",
Review comment:
Honestly, I haven't had that to me. I agree that in most cases this
would not happen(as my last reply said), I’m not against this change, but this
may happen when we set checkpoint interval to very small(maybe in test).
1) we only count `CHECKPOINT_DECLINED` and `CHECKPOINT_EXPIRED` in
`CheckpointFailureManager`, 2) we'll abort snapshot through
`notifyCheckpointAbort` if some checkpoint can't complete
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
