klion26 commented on a change in pull request #13180:
URL: https://github.com/apache/flink/pull/13180#discussion_r473613780
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/AsyncCheckpointRunnable.java
##########
@@ -129,12 +129,10 @@ public void run() {
checkpointMetaData.getCheckpointId());
}
} catch (Exception e) {
- if (LOG.isDebugEnabled()) {
- LOG.debug("{} - asynchronous part of checkpoint
{} could not be completed.",
- taskName,
- checkpointMetaData.getCheckpointId(),
- e);
- }
+ LOG.info("{} - asynchronous part of checkpoint {} could
not be completed.",
Review comment:
Honestly, I haven't had that happen to me. Two more things we may need
to be aware of are that 1)we only count `CHECKPOINT_DECLINED` and
`CHECKPOINT_EXPIRED` in CheckpointFailureManager, 2) we have
`notifyCheckpointAborted` now which will cancel the snapshot of tasks if one
checkpoint can’t complete.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
