[ https://issues.apache.org/jira/browse/FLINK-2523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15139897#comment-15139897 ]
ASF GitHub Bot commented on FLINK-2523: --------------------------------------- Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1612#discussion_r52385223 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java --- @@ -27,13 +24,17 @@ import org.apache.flink.streaming.api.datastream.DataStream; import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment; import org.apache.flink.streaming.api.functions.sink.SinkFunction; -import org.apache.flink.util.InstantiationUtil; +import org.apache.flink.util.InstantiationUtil; import org.junit.Test; +import java.io.IOException; +import java.util.Random; + import static org.junit.Assert.*; -public class StreamingJobGraphGeneratorTest { +public class +StreamingJobGraphGeneratorTest { --- End diff -- why is there a line break after the `class`? > Make task canceling interrupt interval configurable > --------------------------------------------------- > > Key: FLINK-2523 > URL: https://issues.apache.org/jira/browse/FLINK-2523 > Project: Flink > Issue Type: Improvement > Components: TaskManager > Affects Versions: 0.10.0 > Reporter: Stephan Ewen > Assignee: Klou > Fix For: 1.0.0 > > > When a task is canceled, the cancellation calls periodically "interrupt()" on > the task thread, if the task thread does not cancel with a certain time. > Currently, this value is hard coded to 10 seconds. We should make that time > configurable. > Until then, I would like to increase the value to 30 seconds, as many tasks > (here I am observing it for Kafka consumers) can take longer then 10 seconds > for proper cleanup. -- This message was sent by Atlassian JIRA (v6.3.4#6332)