[ 
https://issues.apache.org/jira/browse/FLINK-2523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15121467#comment-15121467
 ] 

ASF GitHub Bot commented on FLINK-2523:
---------------------------------------

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1546#issuecomment-176189641
  
    This is going into a good direction. Two suggestions:
    
      - Since you already have the `ExecutionConfig` in the Task, I would put 
it into the `Environment` from there. Then we could also get rid of the strange 
way of reading the ExecutionConfig in the `AbstractInvokable`
    
      - The ExecutionConfig should be directly attached to the JobGraph, rather 
than written to the job config and read from there.


> Make task canceling interrupt interval configurable
> ---------------------------------------------------
>
>                 Key: FLINK-2523
>                 URL: https://issues.apache.org/jira/browse/FLINK-2523
>             Project: Flink
>          Issue Type: Improvement
>          Components: TaskManager
>    Affects Versions: 0.10.0
>            Reporter: Stephan Ewen
>            Assignee: Kostas
>             Fix For: 1.0.0
>
>
> When a task is canceled, the cancellation calls periodically "interrupt()" on 
> the task thread, if the task thread does not cancel with a certain time.
> Currently, this value is hard coded to 10 seconds. We should make that time 
> configurable.
> Until then, I would like to increase the value to 30 seconds, as many tasks 
> (here I am observing it for Kafka consumers) can take longer then 10 seconds 
> for proper cleanup.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to