[ 
https://issues.apache.org/jira/browse/FLINK-2523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15139908#comment-15139908
 ] 

ASF GitHub Bot commented on FLINK-2523:
---------------------------------------

Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1612#discussion_r52386295
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java ---
    @@ -102,60 +101,150 @@
        // 
--------------------------------------------------------------------------------------------
     
        /**
    -    * Constructs a new job graph with no name and a random job ID.
    +    * Constructs a new job graph with no name, a random job ID, and the 
default
    +    * {@link ExecutionConfig} parameters.
         */
        public JobGraph() {
                this((String) null);
        }
     
        /**
    -    * Constructs a new job graph with the given name, a random job ID.
    +    * Constructs a new job graph with the given name, a random job ID and 
the default
    +    * {@link ExecutionConfig} parameters.
         *
         * @param jobName The name of the job
         */
        public JobGraph(String jobName) {
    -           this(null, jobName);
    +           this(null, jobName, new ExecutionConfig());
    --- End diff --
    
    Why are you creating an empty execution config here?
    
    Is this the execution config which will be passed to the user in the end?


> Make task canceling interrupt interval configurable
> ---------------------------------------------------
>
>                 Key: FLINK-2523
>                 URL: https://issues.apache.org/jira/browse/FLINK-2523
>             Project: Flink
>          Issue Type: Improvement
>          Components: TaskManager
>    Affects Versions: 0.10.0
>            Reporter: Stephan Ewen
>            Assignee: Klou
>             Fix For: 1.0.0
>
>
> When a task is canceled, the cancellation calls periodically "interrupt()" on 
> the task thread, if the task thread does not cancel with a certain time.
> Currently, this value is hard coded to 10 seconds. We should make that time 
> configurable.
> Until then, I would like to increase the value to 30 seconds, as many tasks 
> (here I am observing it for Kafka consumers) can take longer then 10 seconds 
> for proper cleanup.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to