zhuzhurk commented on a change in pull request #12917:
URL: https://github.com/apache/flink/pull/12917#discussion_r459904877
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolImplTest.java
##########
@@ -245,27 +226,25 @@ public void testAllocateWithFreeSlot() throws Exception {
assertTrue(slotPool.offerSlot(taskManagerLocation,
taskManagerGateway, slotOffer));
- LogicalSlot slot1 = future1.get(1, TimeUnit.SECONDS);
+ PhysicalSlot slot1 = future1.get(1, TimeUnit.SECONDS);
assertTrue(future1.isDone());
// return this slot to pool
- slot1.releaseSlot();
+ slotPool.releaseSlot(requestId1, null);
Review comment:
I'd prefer to have this simplification in a separate commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
