Thesharing commented on a change in pull request #12917:
URL: https://github.com/apache/flink/pull/12917#discussion_r459821712
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolImplTest.java
##########
@@ -576,7 +550,6 @@ public void testDiscardIdleSlotIfReleasingFailed() throws
Exception {
try (TestingSlotPoolImpl slotPool = createSlotPoolImpl(clock)) {
setupSlotPool(slotPool, resourceManagerGateway,
mainThreadExecutor);
Review comment:
Because in this commit there is no `createAndSetUpSlotPool(Clock clock)`
method in `SlotPoolImpl` related test cases. In future commits, I replace all
the `createAndSetUpSlotPool` with `SlotPoolBuilder`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
