pnowojski commented on a change in pull request #11687:
URL: https://github.com/apache/flink/pull/11687#discussion_r419942017
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java
##########
@@ -97,6 +100,18 @@ public LocalInputChannel(
// Consume
//
------------------------------------------------------------------------
+ @Override
+ public void readRecoveredState(ChannelStateReader reader) throws
IOException, InterruptedException {
+ synchronized (bufferQueue) {
+ // In most of cases we only need one buffer for reading
recovered state except in very large record case.
+ // Then only one floating buffer is required to avoid
receive more floating buffers after recovery. Even
+ // though we need more buffers for recovery in large
record case, it only increases some interactions with pool.
+ numRequiredBuffers = 1;
+ }
+
+ super.readRecoveredState(reader);
Review comment:
Ops, sorry, that was some older comment that I forgot to remove before
publishing the review :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
