pnowojski commented on a change in pull request #11687: URL: https://github.com/apache/flink/pull/11687#discussion_r419936654
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java ########## @@ -168,6 +175,12 @@ public void run() { Optional<BufferAndAvailability> getNextBuffer() throws IOException, InterruptedException { checkError(); + BufferAndAvailability bufferAndAvailability = getNextRecoveredStateBuffer(); + if (bufferAndAvailability != null) { Review comment: Generally speaking there are no guarantees that data notifications will be accurate or not (I'm not sure if that's the case here). But the code looks a bit strange here and it relays on some extra assumptions. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org