pnowojski commented on a change in pull request #11687: URL: https://github.com/apache/flink/pull/11687#discussion_r419564857
########## File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java ########## @@ -731,33 +726,29 @@ public void testFailureInNotifyBufferAvailable() throws Exception { buffer = checkNotNull(bufferPool.requestBuffer()); // trigger subscription to buffer pool - failingRemoteIC.onSenderBacklog(1); - successfulRemoteIC.onSenderBacklog(numExclusiveBuffers + 1); - // recycling will call RemoteInputChannel#notifyBufferAvailable() which will fail and - // this exception will be swallowed and set as an error in failingRemoteIC + channelWithoutPartition.onSenderBacklog(1); + channelWithPartition.onSenderBacklog(numExclusiveBuffers + 1); + + // recycling will call RemoteInputChannel#notifyBufferAvailable() which will not increase + // the unannounced credit if the channel has not requested partition buffer.recycleBuffer(); - buffer = null; - try { - failingRemoteIC.checkError(); - fail("The input channel should have an error based on the failure in RemoteInputChannel#notifyBufferAvailable()"); - } catch (IOException e) { - assertThat(e, hasProperty("cause", isA(IllegalStateException.class))); - } Review comment: This seems like we are loosing a test coverage here? However this test was quite fragile in the first place and I'm not entirely sure what is it suppose to test. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org