wuchong commented on a change in pull request #11797:
URL: https://github.com/apache/flink/pull/11797#discussion_r413915001
##########
File path: flink-core/src/main/java/org/apache/flink/types/RowKind.java
##########
@@ -38,7 +38,7 @@
* to retract the previous row first. It is useful in cases of a
non-idempotent update, i.e., an
* update of a row that is not uniquely identifiable by a key.
*/
- UPDATE_BEFORE,
+ UPDATE_BEFORE("UB", (byte) 1),
Review comment:
I thought about this. The reason I pick `UB` and `UA` is because Oracle
uses `I` `D` `UO` `UN` to represent these 4 kinds. I think the "U" in the "UB"
string is more meaningful than just a single "B".
Another idea is padding `+` and `-` to `I` `D` `U` to make them have the
same length and still can be distinguished easily. What do you think?
```
I+ | a | 12 | FDF
U- | b | 13 | EFC
U+ | b | 14 | CDE
D- | d | 15 | IKH
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
