wuchong commented on a change in pull request #11797:
URL: https://github.com/apache/flink/pull/11797#discussion_r411200526
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/harness/GroupAggregateHarnessTest.scala
##########
@@ -75,57 +75,57 @@ class GroupAggregateHarnessTest(mode: StateBackendMode)
extends HarnessTestBase(
// register cleanup timer with 3001
testHarness.setProcessingTime(1)
- // accumulate
- testHarness.processElement(new StreamRecord(binaryrow("aaa", 1L: JLong),
1))
- expectedOutput.add(new StreamRecord(binaryrow("aaa", 1L: JLong), 1))
+ // insertion
+ testHarness.processElement(binaryRecord(INSERT,"aaa", 1L: JLong))
Review comment:
Yes. It's unnecessary, because this is a processing-time aggregation
which doesn't depend on event-time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
