wuchong commented on a change in pull request #11797:
URL: https://github.com/apache/flink/pull/11797#discussion_r411461935
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/dataformat/JoinedRow.java
##########
@@ -17,14 +17,16 @@
package org.apache.flink.table.dataformat;
+import org.apache.flink.types.RowKind;
+
/**
* Join two row to one row.
*/
public final class JoinedRow implements BaseRow {
private BaseRow row1;
private BaseRow row2;
- private byte header;
+ private RowKind rowKind = RowKind.INSERT;
Review comment:
This keeps the same behavior as before, default as `INSERT`. And this
also aligns the behavior of our new `GenericRowData`. If we don't have a
default value, then the RowKind will be nullable, and code maybe error-prone.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
