zhengcanbin commented on a change in pull request #11708: [FLINK-15816][k8s]
Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#discussion_r410670682
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesClusterClientFactory.java
##########
@@ -66,6 +67,7 @@ public String getClusterId(Configuration configuration) {
}
private String generateClusterId() {
- return CLUSTER_ID_PREFIX + UUID.randomUUID();
+ final String randomUUID =
UUID.randomUUID().toString().replaceAll("-", "");
Review comment:
> Instead of doing the string replacement, we could also use
>
> this would be a bit simpler.
I agree that the suggested solution would be a bit simpler. The newest
commit has adopted it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
