zhengcanbin commented on a change in pull request #11708: [FLINK-15816][k8s]
Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#discussion_r407819735
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java
##########
@@ -133,8 +133,8 @@
key("kubernetes.cluster-id")
.stringType()
.noDefaultValue()
- .withDescription("The cluster id used for identifying the
unique flink cluster. If it's not set, " +
- "the client will generate a random UUID name.");
+ .withDescription("The cluster-id, which should be no more than
45 characters, is used for identifying " +
Review comment:
Yes. The external Service has a suffix in its name now, and I used to file
another ticket [FLINK-17032](https://issues.apache.org/jira/browse/FLINK-17032)
to unify the naming convention of all the K8s components we created now, so I
think it would be better to leave room for that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
