zhengcanbin commented on a change in pull request #11708: [FLINK-15816][k8s]
Limit the value of kubernetes.cluster-id to have no more than 45 characters
URL: https://github.com/apache/flink/pull/11708#discussion_r407818673
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesClusterClientFactory.java
##########
@@ -66,6 +67,7 @@ public String getClusterId(Configuration configuration) {
}
private String generateClusterId() {
Review comment:
Hi @wangyang0918! The previous pattern is
`flink-cluster-c7ce2409-1542-42d7-9843-ecd64277ea9e`, after this change, the
pattern will be something like `flink-cluster-c7ce2409154242d79843ecd64277ea9`,
which seems more human-readable. Personally I think it does not make too much
sense to obey the default schema of UUID.
But if you insist on the previous pattern, I think we could add the `-` back.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
