KurtYoung commented on a change in pull request #11711:
[FLINK-17103][table-planner-blink] Supports dynamic options for Blink…
URL: https://github.com/apache/flink/pull/11711#discussion_r408122192
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/schema/TableSourceTable.scala
##########
@@ -61,11 +64,33 @@ class TableSourceTable[T](
tableIdentifier.getObjectName),
statistic) {
+ def this(relOptSchema: RelOptSchema,
+ tableIdentifier: ObjectIdentifier,
+ rowType: RelDataType,
+ statistic: FlinkStatistic,
+ tableSource: TableSource[T],
+ isStreamingMode: Boolean,
+ catalogTable: CatalogTable) = this(relOptSchema, tableIdentifier, rowType,
statistic,
+ tableSource, isStreamingMode, catalogTable, Collections.emptyMap())
+
Preconditions.checkNotNull(tableSource)
Preconditions.checkNotNull(statistic)
Preconditions.checkNotNull(catalogTable)
- override def getQualifiedName: JList[String] =
explainSourceAsString(tableSource)
+ override def getQualifiedName: JList[String] = {
+ val sourceExplain = explainSourceAsString(tableSource)
+ if (dynamicOptions.size() == 0) {
+ sourceExplain
+ } else {
+ // Add the dynamic options as part of the table digest,
+ // this is a temporary solution, we expect to avoid this
+ // before Calcite 1.23.0.
Review comment:
Create an issue to track this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
