danny0405 commented on a change in pull request #11711:
[FLINK-17103][table-planner-blink] Supports dynamic options for Blink…
URL: https://github.com/apache/flink/pull/11711#discussion_r407832593
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/CatalogSinkModifyOperation.java
##########
@@ -37,20 +37,23 @@
private final Map<String, String> staticPartitions;
private final QueryOperation child;
private final boolean overwrite;
+ private final List<?> tableHints;
Review comment:
The `RelHint` itself is a POJO which has hint name and hint options as
attributes, passing through these `RelHint`s and hand-over them to planner for
specific manipulation can simplify the codes.
But i'm also fine if we pre-process these `RelHint`s and extract the
contents we care about, such as the dynamic options or some other attributes
(index in the future) directly in `CatalogSinkModifyOperation`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
