danny0405 commented on a change in pull request #11711:
[FLINK-17103][table-planner-blink] Supports dynamic options for Blink…
URL: https://github.com/apache/flink/pull/11711#discussion_r407405012
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/ConnectorCatalogTable.java
##########
@@ -102,6 +102,11 @@ public boolean isBatch() {
throw new UnsupportedOperationException("ConnectorCatalogTable
cannot be converted to properties");
}
+ @Override
+ public CatalogTable copy(Map<String, String> options) {
+ throw new UnsupportedOperationException("ConnectorCatalogTable
cannot copy with new table options");
Review comment:
All the table translating through `CatalogTableImpl` can have valid dynamic
table options, including the table from `TableEnvironment.connect`. There is no
way for a `ConnectorCatalogTable` to override table options because the table
source is already there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
