godfreyhe commented on a change in pull request #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements URL: https://github.com/apache/flink/pull/11700#discussion_r408028219
########## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableResultImpl.java ########## @@ -0,0 +1,334 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.api.internal; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.core.execution.JobClient; +import org.apache.flink.table.api.DataTypes; +import org.apache.flink.table.api.ResultKind; +import org.apache.flink.table.api.TableColumn; +import org.apache.flink.table.api.TableResult; +import org.apache.flink.table.api.TableSchema; +import org.apache.flink.table.utils.EncodingUtils; +import org.apache.flink.types.Row; +import org.apache.flink.util.Preconditions; + +import com.ibm.icu.lang.UCharacter; +import com.ibm.icu.lang.UProperty; +import org.apache.commons.lang3.StringUtils; + +import javax.annotation.Nullable; + +import java.util.ArrayList; +import java.util.Collections; +import java.util.Iterator; +import java.util.List; +import java.util.Optional; + +/** + * Implementation for {@link TableResult}. + */ +@Internal +public class TableResultImpl implements TableResult { + public static final TableResult TABLE_RESULT_OK = TableResultImpl.builder() + .resultKind(ResultKind.SUCCESS) + .tableSchema(TableSchema.builder().field("result", DataTypes.STRING()).build()) + .data(Collections.singletonList(Row.of("OK"))) + .build(); + + // constants for printing + private static final String NULL_COLUMN = "(NULL)"; + private static final int MAX_COLUMN_WIDTH = 30; + private static final String COLUMN_TRUNCATED_FLAG = "..."; + + private final JobClient jobClient; + private final TableSchema tableSchema; + private final ResultKind resultKind; + private final Iterator<Row> data; + + private TableResultImpl( + @Nullable JobClient jobClient, + TableSchema tableSchema, + ResultKind resultKind, + Iterator<Row> data) { + this.jobClient = jobClient; + this.tableSchema = Preconditions.checkNotNull(tableSchema, "tableSchema should not be null"); + this.resultKind = Preconditions.checkNotNull(resultKind, "resultKind should not be null"); + this.data = Preconditions.checkNotNull(data, "data should not be null"); + } + + @Override + public Optional<JobClient> getJobClient() { + return Optional.ofNullable(jobClient); + } + + @Override + public TableSchema getTableSchema() { + return tableSchema; + } + + @Override + public ResultKind getResultKind() { + return resultKind; + } + + @Override + public Iterator<Row> collect() { + return data; + } + + @Override + public void print() { + Iterator<Row> it = collect(); + doPrint(it); + } + + public static Builder builder() { + return new Builder(); + } + + /** + * Builder for creating a {@link TableResultImpl}. + */ + public static class Builder { + private JobClient jobClient = null; + private TableSchema tableSchema = null; + private ResultKind resultKind = null; + private Iterator<Row> data = null; + + private Builder() { + } + + /** + * Specifies job client which associates the submitted Flink job. + * + * @param jobClient a {@link JobClient} for the submitted Flink job. + */ + public Builder jobClient(JobClient jobClient) { + this.jobClient = jobClient; + return this; + } + + /** + * Specifies table schema of the execution result. + * + * @param tableSchema a {@link TableSchema} for the execution result. + */ + public Builder tableSchema(TableSchema tableSchema) { + Preconditions.checkNotNull(tableSchema, "tableSchema should not be null"); + this.tableSchema = tableSchema; + return this; + } + + /** + * Specifies result kind of the execution result. + * + * @param resultKind a {@link ResultKind} for the execution result. + */ + public Builder resultKind(ResultKind resultKind) { + Preconditions.checkNotNull(resultKind, "resultKind should not be null"); + this.resultKind = resultKind; + return this; + } + + /** + * Specifies an row iterator as the execution result . + * + * @param rowIterator a row iterator as the execution result. + */ + public Builder data(Iterator<Row> rowIterator) { + Preconditions.checkNotNull(rowIterator, "rowIterator should not be null"); + this.data = rowIterator; + return this; + } + + /** + * Specifies an row list as the execution result . + * + * @param rowList a row list as the execution result. + */ + public Builder data(List<Row> rowList) { + Preconditions.checkNotNull(rowList, "listRows should not be null"); + this.data = rowList.iterator(); + return this; + } + + /** + * Returns a {@link TableResult} instance. + */ + public TableResult build() { + return new TableResultImpl(jobClient, tableSchema, resultKind, data); + } + } + + /** + * Displays the result in a tableau form. + * For example: + * +-------------+---------+-------------+ + * | boolean_col | int_col | varchar_col | + * +-------------+---------+-------------+ + * | true | 1 | abc | + * | false | 2 | def | + * | (NULL) | (NULL) | (NULL) | + * +-------------+---------+-------------+ + * 3 row(s) in result + * + * <p>Changelog is not supported until FLINK-16998 is finished. + */ + private void doPrint(Iterator<Row> it) { Review comment: Maybe we can move this to `flink-table-common` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
