godfreyhe commented on a change in pull request #11700: [FLINK-16366] [table] 
Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#discussion_r408027710
 
 

 ##########
 File path: flink-table/flink-table-api-java/src/main/resources/META-INF/NOTICE
 ##########
 @@ -0,0 +1,10 @@
+flink-table
+Copyright 2014-2020 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+This project bundles the following dependencies under the BSD license.
+See bundled license files for details.
+
+- com.ibm.icu:icu4j:65.1
 
 Review comment:
   It's also my concern. 
   one approach is we does not support this feature in `TableResult.print`. 
consider that the most uses case of `TableResult.print` is used in IDE for 
debug and demo. In IDEA, even we use `icu4j` to get word width, the result also 
looks irregular when the content contain CJK.
   see the comment in 
[CliTableauResultViewTest#testStreamingResult](https://github.com/apache/flink/blob/master/flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliTableauResultViewTest.java#L290)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to