godfreyhe commented on a change in pull request #11700: [FLINK-16366] [table] 
Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#discussion_r410701769
 
 

 ##########
 File path: flink-table/flink-table-uber-blink/pom.xml
 ##########
 @@ -113,6 +113,13 @@ under the License.
                                                                        
<include>org.apache.flink:flink-cep_${scala.binary.version}</include>
                                                                </includes>
                                                        </artifactSet>
+                                                       <relocations>
+                                                               <relocation>
+                                                                       <!-- 
icu4j's dependencies -->
 
 Review comment:
   because `flink-table-planner-blink` does not package `table-common` into 
jar. If we relocate `icu4j` here and users depends on 
`flink-table-planner-blink` in their project for developing. (that means 
`table-common` will indirectly dependent on) `ClassNotFoundException` will 
occur if user executes `TableResult.print()` in IDE.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to