xintongsong commented on a change in pull request #11675: [FLINK-16745] Use
JobManagerProcessUtils to start JM container and pass JVM memory args
URL: https://github.com/apache/flink/pull/11675#discussion_r407348935
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/deployment/AbstractContainerizedClusterClientFactory.java
##########
@@ -36,9 +38,10 @@
public ClusterSpecification getClusterSpecification(Configuration
configuration) {
checkNotNull(configuration);
- final int jobManagerMemoryMB = ConfigurationUtils
- .getJobManagerHeapMemory(configuration)
- .getMebiBytes();
+ final JobManagerProcessSpec jobManagerProcessSpec =
JobManagerProcessUtils.processSpecFromConfig(
+
JobManagerProcessUtils.getConfigurationWithLegacyHeapSizeMappedToNewConfigOption(
Review comment:
Unrelated:
I was tracking where this method
`getConfigurationWithLegacyHeapSizeMappedToNewConfigOption` lead to, and find
that
`MemoryBackwardsCompatibilityUtils#getLegacyTaskManagerHeapMemoryIfExplicitlyConfigured`
is named "TaskManager" but actually used for both JM & TM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
