xintongsong commented on a change in pull request #11675: [FLINK-16745] Use
JobManagerProcessUtils to start JM container and pass JVM memory args
URL: https://github.com/apache/flink/pull/11675#discussion_r407351155
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
##########
@@ -1570,7 +1573,7 @@ ContainerLaunchContext setupApplicationMasterContainer(
boolean hasLogback,
boolean hasLog4j,
boolean hasKrb5,
- int jobManagerMemoryMb) {
+ ProcessMemorySpec processSpec) {
Review comment:
Why not `JobManagerProcessSpec`? Do we have any use case that possibly pass
in a different `ProcessMemorySpec` implementation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
