zhijiangW commented on a change in pull request #11515: [FLINK-16744][task]
implement channel state persistence for unaligned checkpoints
URL: https://github.com/apache/flink/pull/11515#discussion_r404920180
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriter.java
##########
@@ -73,10 +73,20 @@
void addOutputData(long checkpointId, ResultSubpartitionInfo info, int
startSeqNum, Buffer... data);
/**
- * Finalize write of channel state for the given checkpoint id.
- * Must be called after {@link #start(long)} and all of the data of the
given checkpoint added.
+ * Finalize write of channel state data for the given checkpoint id.
+ * Must be called after {@link #start(long)} and all of the input data
of the given checkpoint added.
+ * When both {@link #finishInput} and {@link #finishOutput} were called
the results can be (eventually) obtained
+ * using {@link #getWriteCompletionFuture}
*/
- void finish(long checkpointId);
Review comment:
we should also adjust the references of `{@link #finish(long)}` in above
`addInputData` and `addOutput` descriptions for the commit "[FLINK-16744][task]
split finish() in ChanStateWrite"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
