zhijiangW commented on a change in pull request #11515: [FLINK-16744][task] 
implement channel state persistence for unaligned checkpoints
URL: https://github.com/apache/flink/pull/11515#discussion_r404804329
 
 

 ##########
 File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/operators/testutils/MockEnvironmentBuilder.java
 ##########
 @@ -154,6 +159,12 @@ public MockEnvironment build() {
                        subtaskIndex,
                        userCodeClassLoader,
                        taskMetricGroup,
-                       taskManagerRuntimeInfo);
+                       taskManagerRuntimeInfo,
+                       memoryManager);
+       }
+
+       public MockEnvironmentBuilder setMemoryManager(MemoryManager 
memoryManager) {
 
 Review comment:
   nit: actually this is not used now in all places and we can add it by 
demands future. If we want to rich the builder now, it is better to place it in 
front of `#build()` to make related methods close with each other.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to