zhijiangW commented on a change in pull request #11515: [FLINK-16744][task]
implement channel state persistence for unaligned checkpoints
URL: https://github.com/apache/flink/pull/11515#discussion_r404908472
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java
##########
@@ -65,6 +75,8 @@ public void checkpointState(
CheckpointMetrics checkpointMetrics,
OperatorChain<?, ?> operatorChain,
Supplier<Boolean> isCanceled) throws Exception {
+ checkNotNull(checkpointOptions);
Review comment:
When checking the commit "[FLINK-16744][task][refactor] inline
CheckpointingOperation", we only `checkNotNull` for `checkpointOptions` and
`checkpointMetrics`. But from the commit "[FLINK-16744][task][refactor]
extract SubtaskCheckpointCoordinator" when this method is firstly introduced,
we did not `checkNotNull` for other arguments which are actually referenced in
that commit, so the criteria seems inconsistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
