GJL commented on a change in pull request #11542: [FLINK-16303][rest] Enable 
retrieval of custom JobManager log files
URL: https://github.com/apache/flink/pull/11542#discussion_r402911592
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorEndpoint.java
 ##########
 @@ -612,16 +615,42 @@ public WebMonitorEndpoint(
                // load the log and stdout file handler for the main cluster 
component
                final WebMonitorUtils.LogFileLocation logFileLocation = 
WebMonitorUtils.LogFileLocation.find(clusterConfiguration);
 
 Review comment:
   I think we can add a field `logDir` to `WebMonitorUtils.LogFileLocation`. 
Also see my other comment.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to