GJL commented on a change in pull request #11542: [FLINK-16303][rest] Enable retrieval of custom JobManager log files URL: https://github.com/apache/flink/pull/11542#discussion_r402910819
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/cluster/JobManagerStdoutFileHandler.java ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.rest.handler.cluster; + +import org.apache.flink.api.common.time.Time; +import org.apache.flink.runtime.rest.handler.HandlerRequest; +import org.apache.flink.runtime.rest.messages.EmptyMessageParameters; +import org.apache.flink.runtime.rest.messages.EmptyRequestBody; +import org.apache.flink.runtime.rest.messages.UntypedResponseMessageHeaders; +import org.apache.flink.runtime.webmonitor.RestfulGateway; +import org.apache.flink.runtime.webmonitor.WebMonitorUtils; +import org.apache.flink.runtime.webmonitor.retriever.GatewayRetriever; + +import java.io.File; +import java.util.Map; + +/** + * Rest handler which serves the stdout file from JobManager. + */ +public class JobManagerStdoutFileHandler extends AbstractJobManagerFileHandler<EmptyMessageParameters> { + + public JobManagerStdoutFileHandler( + GatewayRetriever<? extends RestfulGateway> leaderRetriever, + Time timeout, Map<String, String> responseHeaders, + UntypedResponseMessageHeaders<EmptyRequestBody, EmptyMessageParameters> messageHeaders, + WebMonitorUtils.LogFileLocation logFileLocation) { + super(leaderRetriever, timeout, responseHeaders, messageHeaders, logFileLocation); + } + + @Override + protected File getFile(HandlerRequest<EmptyRequestBody, EmptyMessageParameters> handlerRequest) { + return this.logFileLocation.stdOutFile; Review comment: I find it strange that `JobManagerStdoutFileHandler` also knows about the location of the regular log file (i.e., `LogFileLocation#logFile`). Moreover, we are introducing a class hierarchy without adding behavior, i.e., `JobManagerStdoutFileHandler` and `JobManagerLogFileHandler` are doing the same thing (serving a (log) file). I would propose to drop `JobManagerStdoutFileHandler` and add a `File` field to `JobManagerLogFileHandler`. `JobManagerCustomLogHandler` should have a log dir field. What do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
