GJL commented on a change in pull request #11542: [FLINK-16303][rest] Enable
retrieval of custom JobManager log files
URL: https://github.com/apache/flink/pull/11542#discussion_r405375924
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorUtils.java
##########
@@ -64,16 +64,18 @@
private static final Logger LOG =
LoggerFactory.getLogger(WebMonitorUtils.class);
/**
- * Singleton to hold the log and stdout file.
+ * Singleton to hold the log file, the stdout file, the log directory.
*/
public static class LogFileLocation {
public final File logFile;
public final File stdOutFile;
+ public final String logDir;
- private LogFileLocation(File logFile, File stdOutFile) {
+ private LogFileLocation(File logFile, File stdOutFile, String
logDir) {
Review comment:
Let's add `@javax.annotation.Nullable` for all constructor parameters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
