zhijiangW commented on a change in pull request #11515: [FLINK-16744][task] implement channel state persistence for unaligned checkpoints URL: https://github.com/apache/flink/pull/11515#discussion_r401427977
########## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinator.java ########## @@ -36,7 +37,7 @@ * </ol> */ @Internal -interface SubtaskCheckpointCoordinator { +interface SubtaskCheckpointCoordinator extends Closeable { Review comment: It seems the `close` is never called by `StreamTask`, and this change should be moved into the commit when `SubtaskCheckpointCoordinator` is introduced. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services