zhijiangW commented on a change in pull request #11515: [FLINK-16744][task]
implement channel state persistence for unaligned checkpoints
URL: https://github.com/apache/flink/pull/11515#discussion_r401411590
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/state/TaskStateManagerImpl.java
##########
@@ -68,18 +70,36 @@
/** The checkpoint responder through which this manager can report to
the job manager. */
private final CheckpointResponder checkpointResponder;
+ private final ChannelStateReader channelStateReader;
+
public TaskStateManagerImpl(
- @Nonnull JobID jobId,
- @Nonnull ExecutionAttemptID executionAttemptID,
- @Nonnull TaskLocalStateStore localStateStore,
- @Nullable JobManagerTaskRestore jobManagerTaskRestore,
- @Nonnull CheckpointResponder checkpointResponder) {
+ @Nonnull JobID jobId,
+ @Nonnull ExecutionAttemptID executionAttemptID,
+ @Nonnull TaskLocalStateStore localStateStore,
+ @Nullable JobManagerTaskRestore jobManagerTaskRestore,
+ @Nonnull CheckpointResponder checkpointResponder) {
+ this(jobId,
+ executionAttemptID,
+ localStateStore,
+ jobManagerTaskRestore,
+ checkpointResponder,
+ new ChannelStateReaderImpl(jobManagerTaskRestore ==
null ? new TaskStateSnapshot() : jobManagerTaskRestore.getTaskStateSnapshot())
+ );
+ }
- this.jobId = jobId;
+ TaskStateManagerImpl(
+ @Nonnull JobID jobId,
+ @Nonnull ExecutionAttemptID executionAttemptID,
+ @Nonnull TaskLocalStateStore localStateStore,
+ @Nullable JobManagerTaskRestore jobManagerTaskRestore,
+ @Nonnull CheckpointResponder checkpointResponder,
+ @Nonnull ChannelStateReader channelStateReader) {
+ this.jobId = jobId;
Review comment:
nit: intdentation alignment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
