zhijiangW commented on a change in pull request #11515: [FLINK-16744][task]
implement channel state persistence for unaligned checkpoints
URL: https://github.com/apache/flink/pull/11515#discussion_r401505507
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java
##########
@@ -175,6 +203,77 @@ public void checkpointState(
}
}
+ private OperatorSnapshotFutures buildOperatorSnapshotFutures(
+ CheckpointMetaData checkpointMetaData,
+ CheckpointOptions checkpointOptions,
+ OperatorChain<?, ?> operatorChain,
+ StreamOperator<?> op,
+ Supplier<Boolean> isCanceled,
+ ChannelStateWriteResult channelStateWriteResult) throws
Exception {
+ CheckpointStreamFactory storage =
checkpointStorage.resolveCheckpointStorageLocation(
+ checkpointMetaData.getCheckpointId(),
+ checkpointOptions.getTargetLocation());
+ OperatorSnapshotFutures snapshotInProgress =
checkpointStreamOperator(
+ op,
+ checkpointMetaData,
+ checkpointOptions,
+ storage,
+ isCanceled);
+ if (op == operatorChain.getHeadOperator()) {
+
snapshotInProgress.setInputChannelStateFuture(channelStateWriteResult
+
.getInputChannelStateHandles()
+
.thenApply(StateObjectCollection::new)
+
.thenApply(SnapshotResult::of)
+ );
+ }
+ if (op == operatorChain.getTailOperator()) {
+
snapshotInProgress.setResultSubpartitionStateFuture(channelStateWriteResult
+
.getResultSubpartitionStateHandles()
+
.thenApply(StateObjectCollection::new)
+
.thenApply(SnapshotResult::of)
+ );
+ }
+ return snapshotInProgress;
+ }
+
+ @Override
+ public void close() {
+ channelStateWriter.close();
+ }
+
+ // Caches checkpoint output stream factories to prevent multiple output
stream per checkpoint.
Review comment:
The proper javadoc format for class should be
/**
*
**/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
