rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add
basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r398957647
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
##########
@@ -318,14 +345,16 @@ public void assignExclusiveSegments() throws IOException
{
}
}
- public void setInputChannel(InputChannel inputChannel) {
- checkNotNull(inputChannel);
- IntermediateResultPartitionID partitionId =
inputChannel.getPartitionId().getPartitionId();
+ public void setInputChannels(InputChannel... channels) {
synchronized (requestLock) {
- if (inputChannels.put(partitionId, inputChannel) == null
+ System.arraycopy(channels, 0, this.channels, 0,
numberOfInputChannels);
Review comment:
Looks like this method should be part of constructor (though I see it's a
pre-existing method and may require refactoring).
If not, should we check that new length equals to `numberOfInputChannels`?
If not, should we "truncate" the old values if the new array is shorter?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
