rkhachatryan commented on a change in pull request #11507: [FLINK-16587] Add
basic CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r398943916
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -206,6 +210,20 @@ void retriggerSubpartitionRequest(int subpartitionIndex)
throws IOException {
return Optional.of(new BufferAndAvailability(next,
moreAvailable, getSenderBacklog()));
}
+ @Override
+ public List<Buffer> getInflightBuffers(long checkpointId) throws
IOException {
+ final ArrayList<Buffer> inflightBuffers = new
ArrayList<>(receivedBuffers.size());
Review comment:
Is it a race condition here?
If `receivedBuffers` is currently updated by another thread (even in
`synchronized`) we can read inconsistent state inside `size`, get it negative
and exception in `ArrayList` constructor.
I see think we could use `unsynchronizedGetNumberOfQueuedBuffers()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
