xintongsong commented on a change in pull request #11284:
[FLINK-15911][runtime] Make Flink work with NAT.
URL: https://github.com/apache/flink/pull/11284#discussion_r396896951
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/KvStateService.java
##########
@@ -170,7 +170,7 @@ public static KvStateService
fromConfiguration(TaskManagerServicesConfiguration
int numProxyServerQueryThreads =
qsConfig.numProxyQueryThreads() == 0 ?
taskManagerServicesConfiguration.getNumberOfSlots() :
qsConfig.numProxyQueryThreads();
kvClientProxy =
QueryableStateUtils.createKvStateClientProxy(
-
taskManagerServicesConfiguration.getTaskManagerAddress(),
+
taskManagerServicesConfiguration.getExternalAddress(),
Review comment:
As mentioned in the JIRA ticket, I'd like to exclude queryable state from
the scope of this PR. Because I'm not familiar with how it works, and it seems
does not have many use cases.
I think this should not affect other use cases, because the code path should
only be executed if queryable state is enabled.
I think we should mention in the release notes that the new NAT support does
not cover queryable state.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
